Slider: move by at least the next increment when using fixed_decimals #7066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7066-fix-slider-keyboard-move-max-decimals |
emilk
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
Makes sense! Can you please add a test for this though (using egui_kittest)? I don't think you need a screenshot test, but it would be nice with a test that sets up a value, then injects a arrow key, and then reads back the value to see that it changed by the expected amount.
0x53A
force-pushed
the
fix-slider-keyboard-move-max-decimals
branch
from
7ae7046 to
24e0799
Compare
|
i've manually checked that the test fails on main and succeeds on the branch |
0x53A
force-pushed
the
fix-slider-keyboard-move-max-decimals
branch
from
24e0799 to
33e6fde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7065