Use full root certificate bundle to fix broken OTA updates #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emericklaw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OTA update is broken as discussed in #202 which relates to certificate issues with
objects.githubusercontent.com.The current build only include the common root certificates using
CONFIG_MBEDTLS_CERTIFICATE_BUNDLE_DEFAULT_CMN=yChanging this to
CONFIG_MBEDTLS_CERTIFICATE_BUNDLE_DEFAULT_FULL=ygets OTA updates working again.This does increase the firmware size by 46k but takes the root certificate coverage from 90% to ~100%.
The other alternative is to include the missing root certificate for
Comodo AAA Services rootwhich has been done in the 5.4.1 version of ESP-IDF.espressif/esp-idf@a83a0ab
Either via a patch or upgrading ESP-IDF to 5.4.1 which is covered in #200
This unfortnately means that all current badge users will have to reflash using the web flasher.