Linting fixes #161
Merged
Linting fixes #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this on the simulator but not on a real badge. Some things that need testing:
|
npentrel
reviewed
Jun 19, 2024
Comment on lines
+465
to
+467
| Interrupt = self.i2c.readfrom_mem(self.ADDRESS, self.bc_level_int.register, 1)[ | ||
| 0 | ||
| ] |
There was a problem hiding this comment.
I think this is the more generally accepted way of splitting this line
Suggested change
| Interrupt = self.i2c.readfrom_mem(self.ADDRESS, self.bc_level_int.register, 1)[ | |
| 0 | |
| ] | |
| Interrupt = self.i2c.readfrom_mem( | |
| self.ADDRESS, self.bc_level_int.register, 1)[0] |
There was a problem hiding this comment.
Agreed, i tried this (and the ones above are more readable than the autogenerated one here imo) but ruff keeps reformatting it back to its preferred option - are we happy enough to leave this as is and just merge accepting it looks a little odd?
There was a problem hiding this comment.
Funny. Sure feel free to merge
basic testing (making sure the cable plugged into itself still glows) seems to be fine
all code examples within still work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes should allow the linting and formatting stages to pass.