Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a beta channel #159

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Add support for a beta channel #159

merged 2 commits into from
Jun 17, 2024

Conversation

MatthewWilkes
Copy link
Member

Description

This improves the OTA app to parse version numbers better, with the following rules:

  • Major, Minor and Patch versions are parsed as numbers rather than strings, so v1.10.0 > v1.9.0
  • Development versions where there's a 'number of commits ahead' item are counted as ahead of the version they're on
  • If there's an rc after the patch number, it's treated as ahead of the previous version, so v1.9.0 < v1.10.0rc1 < v1.10.0rc1-1-aaaaaa < v1.10.0 < v1.10.0-1-aaaaaa

If there is an rc in the tag name, it won't overwrite the latest release, it will overwrite the preview release.

The setting update_channel will work as normal if unset or set to latest. Set it to preview to get release candidates.

This improves the OTA app to parse version numbers better, with the following rules:

- Major, Minor and Patch versions are parsed as numbers rather than strings, so v1.10.0 > v1.9.0
- Development versions where there's a 'number of commits ahead' item are counted as ahead of the version they're on
- If there's an rc after the patch number, it's treated as ahead of the previous version, so v1.9.0 < v1.10.0rc1 < v1.10.0rc1-1-aaaaaa < v1.10.0 < v1.10.0-1-aaaaaa

If there is an rc in the tag name, it won't overwrite the `latest` release, it will overwrite the `preview` release.

The setting `update_channel` will work as normal if unset or set to `latest`. Set it to `preview` to get release candidates.
@MatthewWilkes MatthewWilkes requested a review from thinkl33t June 17, 2024 21:14
@thinkl33t
Copy link
Collaborator

Doesn't crash and should work fine - lets try it and revert it if things explode 😁

@thinkl33t thinkl33t merged commit ffe5dcb into main Jun 17, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants