Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved keyboard #113

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Improved keyboard #113

merged 3 commits into from
Jun 9, 2024

Conversation

jake-walker
Copy link
Contributor

@jake-walker jake-walker commented Jun 5, 2024

When I got home and had to type in my WiFi credentials using the old keyboard, it took me so long I decided to crack out my laptop and run code to do it instead. This PR is a bit of an attempt to improve the speed of typing text in on the keyboard.

Each button on the badge corresponds to a group of letters, so the up button does letters a to f, once you press that, the buttons are reassigned letters through that range, so the up button now becomes a. The numbers are part of the uppercase letters (accessed with shift or caps) to keep the keyboard simpler. There's a 'meta' menu with backspace, shift, caps lock, symbols and cancel.

Screen recording of the improved keyboard

The keyboard is compatible with how the old one is used, so no other code needs to be changed.

As I wrote a function to label the buttons, I added yes/no labels to the YesNoDialog in the same way.

@jake-walker
Copy link
Contributor Author

Just need to test this on my physical badge

@jake-walker jake-walker marked this pull request as ready for review June 6, 2024 16:57
@jake-walker
Copy link
Contributor Author

Can confirm the keyboard works on real hardware 🙂

@npentrel
Copy link
Contributor

npentrel commented Jun 9, 2024

I've just tested this as well - it works great! Thank you so much. I'll merge this now and it'll go into the next release (I don't know when that will be)

@npentrel npentrel merged commit ae34919 into emfcamp:main Jun 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants