Skip to content

Minor fixes #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2025
Merged

Minor fixes #265

merged 2 commits into from
Feb 15, 2025

Conversation

octachrome
Copy link
Contributor

@octachrome octachrome commented Oct 27, 2024 •
edited
Loading

Fixed the pins example app, and clarified the name property in metadata.json.

The pins example app had three issues:

  • The app raised an exception when you selected a hexpansion port
  • The graphical indication of the active hexpansion port was off by one
  • There was no way to go back to the hexpansion port selection menu

Tested on badge with the latest firmware.

npentrel
npentrel approved these changes Feb 15, 2025
View reviewed changes
Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@npentrel npentrel merged commit 5d3b847 into emfcamp:main Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npentrel npentrel npentrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@octachrome @npentrel