Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement mininum width for notification #509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implement mininum width for notification #509

wants to merge 1 commit into from

Conversation

apprehensions
Copy link

fixes #69

@apprehensions
Copy link
Author

@emersion ?

@apprehensions
Copy link
Author

@emersion ?

1 similar comment
@apprehensions
Copy link
Author

@emersion ?

emersion
emersion reviewed Mar 16, 2025
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really wrap my head around what this is doing, but it seems like the existing width setting is now ignored?

The original issue is about max-width, and this PR seems to be implementing something else?

@apprehensions
Copy link
Author

The original issue is about max-width, and this PR seems to be implementing something else?

Author wrote:

I use both long and short notification in terms of line lenght. I can set width but that's looking ugly for short notification.

In this PR, width will act as the maximum width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let us set max width. *feature request*
2 participants
@apprehensions @emersion