Enable cardinality constraint in botorch recommender #285
Conversation
Waschenbacher
requested review from
Scienfitz,
AdrianSosic and
AVHopp
as code owners
| @@ -21,8 +21,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| _ `_optional` subpackage for managing optional dependencies | |||
| - Acquisition function for active learning: `qNIPV` | |||
| - Abstract `ContinuousNonlinearConstraint` class | |||
| - `ContinuousCardinalityConstraint` class and corresponding uniform sampling mechanism | |||
| - Abstract `CardinalityConstraint` class and | |||
There was a problem hiding this comment.
@Waschenbacher it seems like this PR is based on top of #270 , right? So please ping me here once that is merged and this is in general ready for review
There was a problem hiding this comment.
Yes, good guess. I have updated the explanation above. Thanks, will ping you and looking forward to your review 👍
Waschenbacher
force-pushed
the
feature/cardinality_constraint_to_botorch
branch
2 times, most recently
from
2145eec
to
ba4dfff
Compare
|
Hi @AVHopp @AdrianSosic @Scienfitz, according to the CI failure I have to fix sth in this PR, so please hold off on the review. I will let you know when it is ready. |
Waschenbacher
force-pushed
the
feature/cardinality_constraint_to_botorch
branch
from
ba4dfff
to
f6dca70
Compare
Waschenbacher
added
the
on hold
|
Hi @AVHopp @Scienfitz , this PR is currently on hold. I had a call with @AdrianSosic and we would need some time to fix. Will let you know when it is ready for review. |
|
@Waschenbacher @AdrianSosic would you be fine with turning this into a draft PR until it is ready for review? |
Scienfitz
removed
the
on hold
This PR enables that cardinality constraints are supported in botorch recommender. It is on the top of #270
ContinuousCardinalityConstrainthas ato_botorchmethod implemented. The continuous cardinality constraints are relaxed to nonlinear inequality constraints, which is supported by botorch'soptimize_acqf.