coordinate time format behavior for date convert in STRING #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update comment fix test case
giwa
force-pushed
the
coordinate-string-date-behavior
branch
from
a0993f8
to
9e59f02
Compare
sonots
requested changes
Jun 10, 2021
| with_typecast_error(val) do |val| | ||
| TimeWithZone.set_zone_offset(Time.parse(val), zone_offset).strftime("%Y-%m-%d") | ||
| end | ||
| } |
There was a problem hiding this comment.
Using @timestamp_format as a flag looks weird because it is not required to parse val here. TIMESTAMP and DATETIME uses @timestamp_format, but DATE does not.
Time.strptime(val, @timestamp_format).strftime("%Y-%m-%d %H:%M:%S.%6N")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since time parse is slow, it's worth to let user select parsing behavior. Somehow DATE convert in STRING does not provide this option.