Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

Fixed infinite loop when using loadSaveData triggering onChange #124

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

parbhatia
Copy link

A bit rushed, this is what I changed to stop infinite rendering when using socket.io and multiple listeners. The basic problem being the inability to stop triggering onChange when loading saved data.

If loadSaveData is provided with a third boolean parameter triggerChange: false, we skip triggering the provided onChange function.

If no triggerChange is provided, it's business as usual.

@embiem
Copy link
Owner

embiem commented Nov 8, 2021

Seems to be related to #93. Thanks for creating the PR!

@MustaRohman
Copy link

Hi @embiem @parbhatia! Thanks for this awesome package and this PR - may I ask, what is the status of this branch? Is there any way I can try to help progress this PR? :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants