-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin support for translations #902
base: main
Are you sure you want to change the base?
Conversation
鉁旓笍 Deploy Preview for ember-website ready! 馃敤 Explore the source changes: 07b3bcc 馃攳 Inspect the deploy log: https://app.netlify.com/sites/ember-website/deploys/621272c5038f360008017dcc 馃槑 Browse the preview: https://deploy-preview-902--ember-website.netlify.app |
|
||
<ul class="list-unstyled"> | ||
<li><a href="https://emberweekend.com/episodes">Ember Weekend</a></li> | ||
<li><a href="https://embermap.com/podcast">Ember Map Podcast</a></li> | ||
{{t "index.learning.podcasts.list" htmlSafe=true}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By putting the whole list in a translation, different languages can either
- swap these with links to the same resources in a different language (maybe that's supported via query params or something),
- add language-specific resources
- replace all the links entirely
@@ -26,6 +26,9 @@ | |||
"start": "ember serve", | |||
"test": "ember test" | |||
}, | |||
"overrides": { | |||
"ember-cli-babel": "^7.26.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this because the console warnings about a bunch of different ember-cli-babel versions kinda make this app look unmaitained 馃槄
@@ -108,6 +112,7 @@ | |||
"algoliasearch" | |||
], | |||
"volta": { | |||
"node": "14.16.0" | |||
"node": "14.16.0", | |||
"npm": "8.5.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm 8+ required for overrides
This pull request has been automatically marked stale. If this pull request is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new pull request if you miss the window. Thanks! |
stalebot is hostile to long-running work. shoo. lol |
This pull request has been automatically marked stale. If this pull request is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new pull request if you miss the window. Thanks! |
Rude, bot |
Implementation prompted by: #901
This will enable users:
Non-goals:
Open for discussion:
Remaining Requirements:
Developing:
Notes on the PR: