Optimize FC layer using TBB, update layer API to choose perf/reference implementation #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 87.71% 85.51% -2.21%
==========================================
Files 18 18
Lines 700 842 +142
Branches 372 448 +76
==========================================
+ Hits 614 720 +106
- Misses 48 52 +4
- Partials 38 70 +32 ☔ View full report in Codecov by Sentry. |
aobolensk
reviewed
Jul 20, 2024
include/layers/Layer.hpp
Outdated
| @@ -18,9 +19,11 @@ enum LayerType { | |||
| kElementWise, | |||
| kConvolution, | |||
| kFullyConnected, | |||
| kOutput, | |||
| kOutput | |||
There was a problem hiding this comment.
Suggested change
| kOutput | |
| kOutput, |
Comment on lines
57
to
61
| std::cerr << "Normal:" << count1 << std::endl; | ||
| double count2 = | ||
| elapsed_time<double, std::milli>(test_func, p2, input, output); | ||
| std::cerr << "Tbb:" << count2 << std::endl; | ||
| // EXPECT_GE(count1, count2); |
There was a problem hiding this comment.
Please clean up debug output and return back text check
| std::cerr << tmp1[i] << ' ' << tmp2[i] << ' ' << i << std::endl; | ||
| } | ||
| } | ||
| // EXPECT_GE(count1, count2); |
There was a problem hiding this comment.
Same, please, enable the check and clean up debug output
…_2023 into neiroyt/feature18_tbbopt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125
Work in progress
By the way, on Windows TBB build itself in another directory, so run_test.exe can't find dlls