Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added http clients in config #1355

Merged
merged 1 commit into from May 6, 2024

Conversation

AbdurNawaz
Copy link
Contributor

@AbdurNawaz AbdurNawaz commented May 3, 2024

Description

embedchain's OpenAI LLM class does not allow the user to provide a custom http client. This can be done through the langchain's ChatOpenAI class which embedchain uses but does not expose the relevant arguments to change the http client. This PR exposes thehttp_client parameter into the config thereby allowing the user to change it.

Fixes #1357

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@AbdurNawaz
Copy link
Contributor Author

@taranjeet @deshraj Can you please take a look

@deshraj deshraj merged commit ebc5e25 into embedchain:main May 6, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http_client variable not available in OpenAILlm class
2 participants