Update HCI types to Bluetooth Core Spec 6.3#75
Open
J0hannes101 wants to merge 8 commits into
Open
Conversation
…omplete to match spec
alexmoon
reviewed
May 11, 2026
Comment on lines
-105
to
+163
| (41, supports_adv_coding_selection_host_support, set_adv_coding_selection_host_support); | ||
| (41, supports_adv_coding_selection_host, set_adv_coding_selection_host); |
Collaborator
There was a problem hiding this comment.
We should avoid unnecessary API changes.
alexmoon
reviewed
May 11, 2026
Comment on lines
+4
to
+7
| /// Extended LMP features that can be viewed as different page types. | ||
| #[derive(Default, Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Hash)] | ||
| #[cfg_attr(feature = "defmt", derive(defmt::Format))] | ||
| pub struct ExtendedLmpFeatures([u8; 8]); |
Collaborator
There was a problem hiding this comment.
This loses type safety by reinterpreting bytes as different values. ReadRemoteExtendedFeaturesComplete needs to provide an API that returns the correct LmpFeaturesMaskPage based on the page_number. An enum would be appropriate for modelling this. You may need to use a custom FromHciBytes implementation instead of using the macro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made:
LmpFeatureMaskPage1/2andLeFeatureMaskPage1for extended feature pagesExtendedLmpFeaturesstruct withas_page_0/1/2()methods for viewing features by pageReadRemoteExtendedFeaturesCompleteevent to use the newExtendedLmpFeaturestypeparam!macro