Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThePhish for Docker on Windows + Docker-Compose Updates #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

asterictnl-lvdw
Copy link

Changes proposed in this pull request

  • Added support to Windows Environment
  • Added a environment that contains the latest versions of Cortex, TheHive and MISP.
  • Changed the configuration around to make it work with TheHive5.
  • Changed the configuration in the Docker-Compose to make Cortex work
  • Changed configuration around to update Cassandra to version 4, elasticsearch to the latest version 7, MySQL to latest version 8 and redis to latest version 6.

The whole procedure has been tested by executing the instructions carefully that are described in the Docker folder.

I recommend a manual review as well.

~LvdW

@emalderson
Copy link
Owner

Hello, sorry for the delay in replying but i'm very busy lately.
Anyway, thank you very much for this amazing contribution! To be honest, the adaptation for Docker Desktop on Windows was not in my plans for two main reasons:

  1. There are no containers that are based on Windows and so the best choice is always to use a Ubuntu VM for testing purposes
  2. The Docker installation method should only be used for testing purposes, because all the configurations made are neither production-ready nor secure.

With that said, although not being a priority for now, I'll take some time to test everything you did on a Windows environment and test with various emails to see if everything is ok before considering the merge. This will however take some time due to my work commitments.
Thank you again for the contribution!

@pir8g33k
Copy link

pir8g33k commented Oct 5, 2022

can we support macos docker ?

@emalderson emalderson mentioned this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants