New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Roslyn server support for C# #4279
base: master
Are you sure you want to change the base?
Conversation
It seems like there is a byte compile error, see https://github.com/emacs-lsp/lsp-mode/actions/runs/7344249257/job/19995837985?pr=4279#step:12:730. 🤔 |
Thanks, it should be fixed now. Is it normal for the other tests to fail? |
I think the piping script may need improvements also. If too many messages overflow the 512 byte buffer they get interspersed and corrupted. It happens when I try to autocomplete something with a lot of candidates. |
It's normal! Don't have to worry about it! |
045dcd2
to
738b0bd
Compare
This is great, by my limited test, it is much faster than omnisharp. One problem I encountered is when saving files it will throw this error
By the way, I can't get the automatic download working, it says 401 Unauthorized, so I manually downloaded it from Download and Release Roslyn. |
It seems in LSP 3.17 it changed that GlobPattern could either be a string or an object with two attributes (baseUri and pattern) |
Does it support the same capabilities? |
Sorry I haven't used it much, but it is the one powering vscode-csharp So I assume it could be quite competent. |
CC: @razzmatazz (the C#/F# maintainer here) @Ruin0x11 Idk what are the |
} catch [System.AggregateException] { | ||
Write-Error $error[0].exception.innerexception | ||
throw $error[0].exception.innerexception | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file for? 🤔 Can you explain it? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This server only supports connecting via named pipes and has no stdin option. However, Emacs does not natively support connecting via named pipes on Windows, so this script is meant as a shim to convert the named pipe I/O to stdin I/O.
Can you resolve conflicts and rebase this? Thanks! |
738b0bd
to
6bf1185
Compare
6bf1185
to
09f9837
Compare
09f9837
to
daf20df
Compare
Adapted code from:
stdpipe.ps1
)Closes #4278.