Allow clients to specify code action arguments where nil values should be treated as :json-false #4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbert-vdh
changed the title
robbert-vdh
commented
Oct 14, 2023
lsp-mode.el
Outdated
| (lsp-put structure key :json-false))) | ||
| ;; If `key' does not exist, then we'll silently ignore it | ||
| (when-let ((child (lsp-get structure key))) | ||
| (lsp--fix-nested-boolean child rest)))) |
There was a problem hiding this comment.
I'm not very familiar with elisp and its data structures, so maybe there's an existing/better combinator for doing deep queries/updates in nested hash tables.
This lets us fix emacs-lsp#4184 by selectively changing `nil` code action argument values to `:json-false`. Once this is merged, HLS needs to set the field to `'(:withSig)` (and possibly some other values).
robbert-vdh
force-pushed
the
robbert-vdh/patch-boolean-action-values
branch
from
85d97a5
to
54b971e
Compare
|
Thank you for your PR. I would like the implementation to be changed a bit. In this PR the client is supposed to use some description of the fixes to be applied which may or may not cover all cases. (e. g. it may depend on more context and so on). So instead of having the logic here in lsp-mode I would like to be pushed into the client. That can happen if lsp-mode receives a function from the client and then only applies it to the result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us fix #4184 by selectively changing
nilcode action argument values to:json-false. Once this is merged, HLS needs to set the field to'(:withSig)(and possibly some other values).Some possible alternatives to this would be to:
boolean-action-argumentsinto an alist that matches (part of) the command's name. This needs to support partial matches because HLS includes a plugin ID in the command name, and these are not guaranteed to stay constant.Supersedes #4191.