Make lsp-fsharp directory exclusion more configurable #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows users of this code to add extra directories to be ignored during project loading, which can be extremely useful while also using toolsets like Nix (which may symlink other F# projects in to the repo, thus confounding project loading).
yyoncho
reviewed
May 14, 2023
clients/lsp-fsharp.el
Outdated
| (defcustom lsp-fsharp-workspace-extra-exclude-dirs '() | ||
| "Additional directories to exclude from FsAutoComplete workspace loading / discovery." | ||
| :group 'lsp-fsharp | ||
| :type '(repeat string)) |
There was a problem hiding this comment.
it should be lsp-string-vector. Why did you change the default?
There was a problem hiding this comment.
Oh jeeze, I completely lost track of this. Apologies!
I'll get this updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users of this code to add extra directories to be ignored during project loading, which can be extremely useful while also using toolsets like Nix (which may symlink other F# projects in to the repo, thus confounding project loading).
Closes #4048.