Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use crystalline instead of scry for Crystal (#4003) #4007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use crystalline instead of scry for Crystal (#4003) #4007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.org
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
one installed by lsp-mode.
* Add [[https://github.com/charliermarsh/ruff-lsp][ruff-lsp]] support (additional server for Python).
* Update documentation of Vue3 install server
* Change Crystal server from ~scry~ to ~crystalline~
** Release 8.0.0
* Add ~lsp-clients-angular-node-get-prefix-command~ to get the Angular server from another location which is still has ~/lib/node_modules~ in it.
* Set ~lsp-clients-angular-language-server-command~ after the first connection to speed up subsequent connections.
Expand Down
14 changes: 7 additions & 7 deletions clients/lsp-crystal.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,21 @@

(require 'lsp-mode)

(defgroup lsp-scry nil
"LSP support for Crystal via scry."
(defgroup lsp-crystalline nil
"LSP support for Crystal via crystalline."
:group 'lsp-mode
:link '(url-link "https://github.com/crystal-lang-tools/scry"))
:link '(url-link "https://github.com/elbywan/crystalline"))

(defcustom lsp-clients-crystal-executable '("scry" "--stdio")
"Command to start the scry language server."
:group 'lsp-scry
(defcustom lsp-clients-crystal-executable '("crystalline" "--stdio")
"Command to start the crystalline language server."
:group 'lsp-crystalline
:risky t
:type 'file)

(lsp-register-client
(make-lsp-client :new-connection (lsp-stdio-connection lsp-clients-crystal-executable)
:major-modes '(crystal-mode)
:server-id 'scry))
:server-id 'crystalline))

(lsp-consistency-check lsp-crystal)

Expand Down
6 changes: 3 additions & 3 deletions docs/lsp-clients.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@
{
"name": "crystal",
"full-name": "Crystal",
"server-name": "scry",
"server-url": "https://github.com/crystal-lang-tools/scry",
"installation-url": "https://github.com/crystal-lang-tools/scry#installation",
"server-name": "crystalline",
"server-url": "https://github.com/elbywan/crystalline",
"installation-url": "https://github.com/elbywan/crystalline#installation",
"debugger": "Not available"
},
{
Expand Down