Fix lsp--suggest-project-root always suggesting something #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts emacs-lsp#2112. The intent of `lsp--suggest-project-root` is not to always return non-nil but instead return nil when no good suggestion is found and let the caller decide what to do in such case. This can be seen in 2 different ways: 1. All calls except in `lsp--calculate-root` (see 2 below) use the following form which demonstrates that the function should sometimes return nil. ``` (or (lsp--suggest-project-root) default-directory) ``` 2. We find the following snippet in `lsp--calculate-root` which demonstrates that the function should sometimes return nil (otherwise `unless lsp-auto-guess-root` could be removed since always true). ``` (or (when lsp-auto-guess-root (lsp--suggest-project-root)) (lsp-find-session-folder session file-name) (unless lsp-auto-guess-root ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #2112.
The intent of
lsp--suggest-project-rootis not to always return non-nil but instead return nil when no good suggestion is found and let the caller decide what to do in such case. This can be seen in 2 different ways:All calls except in
lsp--calculate-root(see 2 below) use the following form which demonstrates that the function should sometimes return nil.We find the following snippet in
lsp--calculate-rootwhich demonstrates that the function should sometimes return nil (otherwiseunless lsp-auto-guess-rootcould be removed since always true).