Use a more performant org-cite activate processor by default

[krisbalintona]

As described in #842, citar uses the built-in org-cite-basic-activate which can cause significant slowdowns. This PR defines our own activate function, citar-org-cite-basic-activate, and uses it by default (replaces org-cite-basic-active in citar-org-activation-functions). This new activate function is identical to the built-in basic activate function but uses citar functions to speed up the expensive operations of the built-in activate function.

[bdarcus]

Thanks!

The CI has picked up a linting error. Can you see about fixing that?

Come to think about it, it may be related to an earlier issue. I'll check back later today though.

EDIT: looks like recently org devs moved org-element-property and org-element-type to a new org-element-ast.el, that's what generating the error. Not sure how to address that ATM.

Seems like maybe:

(if (require 'org-element-ast nil 'noerror)
  (require 'org-element)
  (message "Loaded org-element"))

... and:

(if (featurep 'org-element-ast)
    (declare-function org-element-property "org-element-ast")
  (declare-function org-element-property "org-element"))

[krisbalintona]

So, to be clear, should I be waiting for a resolution on main?

[bdarcus]

So, to be clear, should I be waiting for a resolution on main?

I don't think it matters. I was partly just updating to add notes for myself.

If I update it on main before merging, do you think it will be a problem for you?

[krisbalintona]

If I update it on main before merging, do you think it will be a problem for you?

Nope, no problem for me 👍

[bdarcus]

I ended up merging this first, as I haven't yet figured out how to fix the issue with Emacs Master.

[krisbalintona]

I ended up merging this first, as I haven't yet figured out how to fix the issue with Emacs Master.

Sounds good. Thank you!