Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ToolbarButton widget library #3282

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

caponetto
Copy link
Contributor

What changes were proposed in this pull request?

Closes #2375

It's a quick win to be included in the release, although no visual changes are expected.

image

How was this pull request tested?

Through CI runs and manual tests.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Guilherme Caponetto <[email protected]>
@caponetto caponetto requested a review from lresende January 21, 2025 17:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d23c719). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3282   +/-   ##
=======================================
  Coverage        ?   83.67%           
=======================================
  Files           ?      160           
  Lines           ?    19987           
  Branches        ?      515           
=======================================
  Hits            ?    16725           
  Misses          ?     3077           
  Partials        ?      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caponetto
Copy link
Contributor Author

Regarding the CodeCov comment: I have requested the app to be installed for this repository. I guess an admin needs to accept it. cc @lresende

@lresende lresende merged commit 408f4f8 into elyra-ai:main Jan 23, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ToolbarButton widget library
3 participants