Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python formatting to get rid of linter errors from make lint-server #3260

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

jiridanek
Copy link
Contributor

@jiridanek jiridanek commented Dec 23, 2024

What changes were proposed in this pull request?

This fixes the following errors, that were previously reported

make lint-server
python3 -m flake8 elyra .github
elyra/tests/metadata/test_metadata.py:707:28: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:90:47: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:119:41: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:119:51: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:178:52: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:207:46: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:207:56: E226 missing whitespace around arithmetic operator
make: *** [lint-server] Error 1

How was this pull request tested?

Run the command that was previously failing in CI

Developer's Certificate of Origin 1.1

       By making a contribution to this project, I certify that:

       (a) The contribution was created in whole or in part by me and I
           have the right to submit it under the Apache License 2.0; or

       (b) The contribution is based upon previous work that, to the best
           of my knowledge, is covered under an appropriate open source
           license and I have the right under that license to submit that
           work with modifications, whether created in whole or in part
           by me, under the same open source license (unless I am
           permitted to submit under a different license), as indicated
           in the file; or

       (c) The contribution was provided directly to me by some other
           person who certified (a), (b) or (c) and I have not modified
           it.

       (d) I understand and agree that this project and the contribution
           are public and that a record of the contribution (including all
           personal information I submit with it, including my sign-off) is
           maintained indefinitely and may be redistributed consistent with
           this project or the open source license(s) involved.

…ver`

```
make lint-server
python3 -m flake8 elyra .github
elyra/tests/metadata/test_metadata.py:707:28: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:90:47: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:119:41: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:119:51: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:178:52: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:207:46: E226 missing whitespace around arithmetic operator
elyra/tests/util/test_kubernetes.py:207:56: E226 missing whitespace around arithmetic operator
make: *** [lint-server] Error 1
```

Signed-off-by: Jiri Daněk <[email protected]>
@lresende lresende added this to the 4.0.0 milestone Dec 24, 2024
@lresende lresende merged commit 4ad2b40 into elyra-ai:main Dec 25, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants