Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DAG repo to airflow submission response messages #2103

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

kevin-bates
Copy link
Member

This pull request updates the submission response message to include the GitHub URL that contains the uploaded Airflow DAG. This addition only occurs if the response object contains a git_url attribute.

Note: this logic will need to be revisited once we decouple the platform runtimes from the front-end (as part of #2100), at which time I suspect the response object will also include the message text appropriate to the platform runtime.

How was this pull request tested?

The current automation tests don't cover submission, so this was manually verified using an appropriate pipeline and produced this output:

 $ elyra-pipeline submit --runtime-config af_teacloth1 my_pipeline/kb1_nb_only.pipeline 

────────────────────────────────────────────────────────────────
 Elyra Pipeline Submission
────────────────────────────────────────────────────────────────

Validating pipeline...
 [Warning][Prepare for the apocalypse now!][label] - The node label contains characters that may be replaced by the runtime service. Node labels should start with lower case alphanumeric and contain only lower case alphanumeric, underscores, dots, and dashes. The current property value is 'Prepare for the apocalypse now!'.
 [Warning][Finalize][label] - The node label contains characters that may be replaced by the runtime service. Node labels should start with lower case alphanumeric and contain only lower case alphanumeric, underscores, dots, and dashes. The current property value is 'Finalize'.
 [Warning][Process][label] - The node label contains characters that may be replaced by the runtime service. Node labels should start with lower case alphanumeric and contain only lower case alphanumeric, underscores, dots, and dashes. The current property value is 'Process'.

❯ Job submission succeeded
  Apache Airflow DAG has been pushed to: https://github.com/akchinstc/test-repo/tree/test
  Check the status of your job at: http://teacloth1.fyre.ibm.com:31187
  The results and outputs are in the /kbates/kb1_nb_only-0902134652 
  working directory in http://cloning1.fyre.ibm.com:31467


────────────────────────────────────────────────────────────────
 Elyra Pipeline Submission Complete
────────────────────────────────────────────────────────────────

Resolves #2101

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Sep 2, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akchinSTC akchinSTC merged commit 88f1c29 into elyra-ai:master Sep 3, 2021
@lresende lresende added this to the 3.1.0 milestone Sep 3, 2021
@kevin-bates kevin-bates deleted the cli-airflow-submit branch September 11, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'elyra-pipeline submit' confirmation message does not expose DAG repo link
5 participants