Observables: search inside added/removed nodes #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're working with pages that are rendered depending on API requests, so we do something like this:
Because of some interaction between react-dom and Intersection Observer API that I don't really understand, mutationObservables is not deterministic, sometimes it gets the element I'm looking for (
<div id="create_question">...</div>
), sometimes it gets an ancestor (<div ...>...<div id="create_question">...</div>...</div>
) and not always the same ancestor. When it gets an ancestor, it doesn't match the selector and so it doesn't refresh.This PR makes Observables search inside the added/removed elements instead of just looking at them.