Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make PR template #336

Merged
merged 1 commit into from
Sep 28, 2017
Merged

make PR template #336

merged 1 commit into from
Sep 28, 2017

Conversation

DQNEO
Copy link
Collaborator

@DQNEO DQNEO commented Sep 28, 2017

#264 の代替品です。

PR作成時に適用されるテンプレートを作ってみました。

https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/

@llminatoll
Copy link
Collaborator

ありがとうございます!素晴らしいですね 🎉✨
マージします!!

@llminatoll llminatoll merged commit 716500c into elmas3:master Sep 28, 2017
@DQNEO DQNEO deleted the patch-1 branch September 28, 2017 13:35
@DQNEO
Copy link
Collaborator Author

DQNEO commented Sep 29, 2017

文言は適当に書いたやつなので自由に改変してもらって大丈夫です。(言うまでもないことですが)

それと、今プルリを作ったらちゃんとテンプレートが適用されていることを確認しました。

2017-09-29 19 55 21

@llminatoll
Copy link
Collaborator

llminatoll commented Oct 1, 2017

ありがとうございます!
テンプレートの文章に合わせてリポジトリのdescriptionも修正しておきました!

変更前

default

変更後

default

@DQNEO
Copy link
Collaborator Author

DQNEO commented Oct 2, 2017

LGTM 👍

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants