Add FAMS code in individual nodes when made a spouse in a family. #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually FAMC was easier than I thought as there isn't a corresponding RemoveChild() -- yet. |
elliotchance
requested changes
May 6, 2020
elliotchance
approved these changes
May 8, 2020
elliotchance
pushed a commit
that referenced
this pull request
May 9, 2020
This fixes a bug from a previous patch in #310.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should add a FAMS record to the individual when they are added as a spouse to a family node. See #309 I hope I handled the cache values appropriately, originally that was confusing me as to why my delete tests were failing, although GEDCOMString() was showing what I expected.
I'll tackle children (FAMC) codes separately, soon.
This change is