feat: set media player preference as enabled by default#3271
feat: set media player preference as enabled by default#3271ayo-run wants to merge 3 commits intoelk-zone:mainfrom
Conversation
- set preference as true - promote embedded media player as not experimental
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for elk-docs canceled.
|
|
Restore old experimental value and delete it once the new preference saved (the problem, we don't know if the user has disabled the experimental feature so we need to restore the original value if experimental still there, otherwise we don't need to change the new feature since it is enabled by default) /cc @patak-dev @shuuji3 |
|
I will check, thanks!! |
…a-player-as-not-experimental
✅ Deploy Preview for elk-docs canceled.
|
|
Since setting this as default means we think it's stable and recommend using it, I think we could let this one time change and merge it as is? (For me, I've been using this nice player for a while and haven't seen any issues.) Some people might have tried it and turned it off, but I think there are many more people who haven't even tried it yet. Keeping the existing value will let those people miss this useful feature after that. |
|
The current default value is |
|
Thanks @shuuji3 for checking! I agree that this feature is now stable and should be a default. I need to re-check the settings stored, but overall I feel it should be fine for a the users who enabled this to see some unexpected changes on their experience as that's the reason we marked this as experimental. |
Proposal to promote the media player as not experimental 😄
We decided to put this feature as experimental to gather feedback and bug reports. I looked through the issues to see if there are complaints regarding the media player, but there seems to be none! 🎉
This PR will