Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VP8 simulcast #198

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Add support for VP8 simulcast #198

merged 1 commit into from
Feb 17, 2025

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Feb 13, 2025

This PR moves and adjusts VP8 simulcast code from Membrane RTC Engine

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 76.08696% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.97%. Comparing base (4cebfd8) to head (3bc96f7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/rtp/munger.ex 58.82% 7 Missing ⚠️
lib/ex_webrtc/rtp/vp8.ex 0.00% 3 Missing ⚠️
lib/ex_webrtc/rtp/vp8/munger.ex 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   85.29%   84.97%   -0.32%     
==========================================
  Files          49       51       +2     
  Lines        2584     2629      +45     
==========================================
+ Hits         2204     2234      +30     
- Misses        380      395      +15     
Files with missing lines Coverage Δ
lib/ex_webrtc/rtp/vp8/munger.ex 96.15% <96.15%> (ø)
lib/ex_webrtc/rtp/vp8.ex 0.00% <0.00%> (ø)
lib/ex_webrtc/rtp/munger.ex 84.78% <58.82%> (-15.22%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cebfd8...3bc96f7. Read the comment docs.

@mickel8 mickel8 force-pushed the vp8-simulcast branch 6 times, most recently from c7f2532 to 6ceda37 Compare February 16, 2025 10:37
@mickel8 mickel8 marked this pull request as ready for review February 16, 2025 11:40
@mickel8 mickel8 merged commit 7f1a127 into master Feb 17, 2025
3 checks passed
@mickel8 mickel8 deleted the vp8-simulcast branch February 17, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants