[ 377 ] Add crash_report logger metadata for exceptions captured by Cowboy.Handler
#381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleipnir
requested changes
Jul 11, 2024
|
@beligante I only presented one argument in my review. If you can address it I will proceed with approval. |
sleipnir
reviewed
Jul 11, 2024
Co-authored-by: Adriano Santos <[email protected]>
Co-authored-by: Adriano Santos <[email protected]>
Co-authored-by: Adriano Santos <[email protected]>
Co-authored-by: Adriano Santos <[email protected]>
Co-authored-by: Adriano Santos <[email protected]>
Co-authored-by: Adriano Santos <[email protected]>
|
Yup! Those LGTM! |
Just don't forget to rename the adapter_exception.ex to report_exception.ex |
Nice catch! I forgot about that detail. Thanks |
sleipnir
approved these changes
Jul 11, 2024
|
LGTM @beligante |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces #377
This change aims to follow the elixir standard to make usage of
crash_reportmetadata as listed here so that users can access these with additional information about the request and connection.One example of usage for this is the platforms for bug reports such as Sentry or Bugsnag. A user can implement its own logger backend and process the log lines that contains crash_report metadata. Notice that we're normalizing the exceptions based on the elixir docs
One extra thing changed here: Use
:proc_lib.start_linkwhich is a erlang module that also adds crash_report to processes