-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and fix datafile accessions #98
Open
kdp-cloud
wants to merge
13
commits into
main
Choose a base branch
from
cleanup_and_fix_datafile_accessions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kdp-cloud
commented
Jan 3, 2025
•
edited
Loading
edited
- Cleaning up of mars_cli.py
- Better logging:
- extra handler for stdout, with color-coded formatting for different logging levels, instead of printing to stdout.
- logs in stdout are identical to the ones in the logfiles
- logs from external libraries are also logged
- Adds Study related accessions as a study comment. E.g. If ENA returns the Study accession 'ERP167466' in the receipt. it will add the following comment:
- Add it as a comment in the assay as well
- Add datafile accessions to the updated ISA-JSON
Replaces repository agnostic 'accession' comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.