Handle zero-length files with no read permission #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwaller-arm
force-pushed
the
zero-length-files
branch
4 times, most recently
from
98a76e9
to
a1a52dd
Compare
|
I consider this ready for review and testing but please leave the merging to me, I want to test it a bit more first. |
peterwaller-arm
force-pushed
the
modes
branch
from
7b5882f
to
d8242b8
Compare
peterwaller-arm
force-pushed
the
zero-length-files
branch
from
a1a52dd
to
b39c6e5
Compare
peterwaller-arm
force-pushed
the
modes
branch
from
d8242b8
to
dbcff1b
Compare
peterwaller-arm
force-pushed
the
zero-length-files
branch
from
b39c6e5
to
8112284
Compare
This is a nop change to introduce a parameter which enables us to control the permissions of the created file. Since it defaults to the old behaviour, no functional changes are intended (NFC).
Soon introducing file metadata as distinct from object metadata. Object metadata: That which relates to the object as it appears in the pack. File metadata: That which relates to the path, such as file modes.
This adds a FileMetadata as a part of the FileHandle. This does make me question if FileHandle is now appropriately named, but logically, the file metadata is a part of the file state which should be considered changed along with the other properties of the FileHandle, so this seems like the correct place to put this information for now.
Prior to this commit, modes did nothing since they were not populated. After this commit, they are populated in the index, and that information is used to specify modes on the created files. Closes #13.
Addresses a review comment in #107.
It appears to be optional on an old Ubuntu installation, but in more recent versions of nc, -p is rejected with -l.
These files appear for example in clang's test suite, for testing the behaviour of tooling when it tries to read files it lacks the permission for. So this is a step towards being able to store more directories without manual intervention. Closes #14.
peterwaller-arm
force-pushed
the
zero-length-files
branch
from
8112284
to
714eb98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files appear for example in clang's test suite, for testing the behaviour of tooling when it tries to read files it lacks the permission for. So this is a step towards being able to store more directories without manual intervention.
Closes #14.
TODO