Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus current tab #638

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Focus current tab #638

merged 10 commits into from
Sep 5, 2024

Conversation

igordsm
Copy link
Sponsor Contributor

@igordsm igordsm commented Nov 7, 2021

Fix #73

Tested this with multiple terminal windows and tabs. should work without issues.

@jeremypw
Copy link
Collaborator

jeremypw commented Nov 10, 2021

Is it necessary to add another dependency (especially X11 specific)? Is using "get_server_time" essential?

@igordsm
Copy link
Sponsor Contributor Author

igordsm commented Nov 13, 2021

@jeremypw Unfortunately it seems get_server_time is essential. Apparently present_with_time needs a timestamp to solve focus stealing and the only timestamp I passed to it that worked was this one. Using regular datetime functions did not work and I found an answer in SO that linked to this function.

src/Application.vala Outdated Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
@jeremypw
Copy link
Collaborator

Might be worth delaying trying to fix this until elementary/notifications#153 is fixed. It should not be necessary to add that extra dependency.

@jeremypw
Copy link
Collaborator

Need to find a solution that works on Wayland.

@jeremypw
Copy link
Collaborator

jeremypw commented Sep 3, 2024

@Marukesu I think a dependency on gdk-wayland-3.0 may be required to make it work under Wayland. This should not be necessary under Gtk4, so maybe better to wait for the Gtk4 port to land to fix Wayland? If so, maybe this can be merged so that it at least works on OS7.1 and in "Compatability Mode".

@Marukesu
Copy link
Contributor

Marukesu commented Sep 5, 2024

I think it should be fine for what the notification sever can do right now.

We really need to have the Gtk Notification interface implemented there to have the true timestamp of the event, but that can be done later.

@jeremypw jeremypw merged commit d766dbd into elementary:master Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open relevant tab when clicking on a task finished notification
3 participants