-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open relevant tab when clicking on a task finished notification #73
Comments
I'm working on this. I have a working prototype and will send a PR later when I finish cleaning the code. |
@igordsm You can always open a draft PR while your working on it for better visibilty 😄 |
I think this used to work, not long ago (maybe OS6?), but nowadays clicking the notification will instead do one of these two actions:
This is even if my command was actually running in different tab in different directory. Clicking the notification always goes Home. |
Worth looking at this again now some systemic issues with the notification handling are fixed. |
I realized my wording had some untested assumption, so I tested it and it still holds - the above statement is even true if I open two tabs with Home directory and run e.g. |
#638 now works on X11 but I think fixing for Wayland under Gtk3 might need the addition of another dependency ( |
It got better recently, I think there is still something off with it, but now after vacation I don't recall what it was and I'm busy with other work. I'll see next week, as I'll be making hundreds of plots in Jupyter, so it should come up... PS: I've run flatpak update just to do a quick test. I switched to different terminal tab, and then to different app. Clicking the notification brings terminal in focus, but not the correct tab, just the tab I selected before leaving it. It no longer creates new Home tab, so that's fixed. Version is reported as 6.2.0. |
@jeremypw I'm aware of that, but your comment reminded me of previous improvements I wanted to mention here. These happened some weeks ago and made the issue less bad. |
I had two tabs open, with a process running in tab two. When it finished, I received a notification (sweet!) but clicking the tab showed me Terminal with the first tab active, not the second one (not so sweet).
Ideally, whichever tab emitted the notification should be the active tab if a notification is clicked upon.
Launchpad Details: #LP1642970 Ruppal Singh - 2016-11-18 14:08:49 +0000
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: