Update Send button bg color#5170
Merged
Merged
Conversation
Member
|
It's not wrong. It does look out of place. |
Member
|
Noting that this is blocked for now as the send button should also be styled with Liquid Glass on iOS 26 |
pixlwave
force-pushed
the
Aaron/send-button
branch
from
25bfce6 to
605d4ae
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5170 +/- ##
===========================================
- Coverage 74.72% 74.69% -0.03%
===========================================
Files 790 794 +4
Lines 52859 52902 +43
===========================================
+ Hits 39497 39515 +18
- Misses 13362 13387 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
reviewed
Mar 22, 2026
pixlwave
force-pushed
the
Aaron/send-button
branch
from
605d4ae to
c8c3aa7
Compare
6 tasks
Change the gradient bg to accent/rest.
Also simplifies the tests a bit.
Also use the same sizes in both the message bubbles and the composer. # Conflicts: # ElementX/Sources/Screens/Timeline/View/Replies/TimelineReplyView.swift
- Container size = 36x36px - Icon size = 24x24px
pixlwave
force-pushed
the
Aaron/send-button
branch
3 times, most recently
from
518c4a4 to
7756af3
Compare
Member
|
No longer blocked, this now contains the glass updates. |
pixlwave
requested review from
a team and
Velin92
and removed request for
a team
pixlwave
force-pushed
the
Aaron/send-button
branch
from
1d46b42 to
8cb62fc
Compare
Velin92
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the gradient bg to accent/rest.
We talked about killing the accent button generally, but the Send button currently has a gradient bg - which looks out of place with the rest of the app. @amshakal do you agree with this?
Pull Request Checklist
UI changes have been tested with: