-
Notifications
You must be signed in to change notification settings - Fork 368
Voice message: variable play back speed #5963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Add playback speed control for voice messages with support for 0.5×, 1×, 1.5×, and 2× playback speeds. The speed button is displayed above the timestamp and cycles through the available speeds when tapped.
Add variable playback speed feature for voice messages
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5963 +/- ##
===========================================
- Coverage 81.40% 81.35% -0.05%
===========================================
Files 2535 2538 +3
Lines 67626 67682 +56
Branches 8669 8677 +8
===========================================
+ Hits 55049 55065 +16
- Misses 9367 9404 +37
- Partials 3210 3213 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



Content
Follow up PR for #5504 .
Last commits are cleanup.
Also I stored the playback speed index into a data store, since not doing this was causing issue when multiple voice messages was displayed on screen and also difference between the speed displayed on screen and the actual speed of the player. With the data store, everything stays in sync and is persisted across application restart. I do not see the point to persist a different speed depending on the account (in case multi account is used), but we may want to improve this later.
Motivation and context
Give the user the ability to change the playback speed of voice messages.
Screenshots / GIFs
See recorded ones
Tests
The same tests can be done when playing the voice messages from the media gallery (files tab).
Tested devices
Checklist