Skip to content

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Dec 30, 2025

The boolean isUpdated will be passed to setOnlyAlertOnce(), and when the value is true, the notification does not ring/vibrate again.

Content

Make the notification silent when the message is an outgoing message
The boolean isUpdated will be passed to setOnlyAlertOnce(), and when the value is true, the notification does not ring/vibrate again.

Motivation and context

Closes #5954

Screenshots / GIFs

Tests

  • Receive a notification -> notification is noisy
  • Expand the notification to where quick replies are showing
  • reply from the notification -> the notification is silently updated.

Previously, the notification was ringing/vibrating again.

Note that the behavior may depend on device OS version.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

…(quick reply).

The boolean isUpdated will be passed to setOnlyAlertOnce(), and when the value is true, the notification does not ring/vibrate again.
@bmarty bmarty requested a review from a team as a code owner December 30, 2025 16:10
@bmarty bmarty requested review from ganfra and removed request for a team December 30, 2025 16:10
@bmarty bmarty added the PR-Bugfix For bug fix label Dec 30, 2025
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/oZ5W8i

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.40%. Comparing base (3973616) to head (7576a97).

Files with missing lines Patch % Lines
...push/impl/notifications/RoomGroupMessageCreator.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5961      +/-   ##
===========================================
- Coverage    81.40%   81.40%   -0.01%     
===========================================
  Files         2535     2535              
  Lines        67626    67626              
  Branches      8669     8670       +1     
===========================================
- Hits         55049    55048       -1     
  Misses        9367     9367              
- Partials      3210     3211       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Bugfix For bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick-replying to a notification causes the phone to vibrate

2 participants