Fix : iterate on unban permissions

[ganfra]

Content

After more tests on our side (and digging with the backend team), we need both kick and ban permissions to unban someone.
Also we reverted the logic for displaying banned users to having the ban permission.

Motivation and context

Better ux.

Screenshots / GIFs

No ui change.

Tests

• Tweaks the PowerLevel so you have the PL for ban but not kick
• Long click on a member in the member list
• Check you can only ban the member
• Go to the banned tabs, and check you cannot unban him.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Qz2oep

[codecov]

Codecov Report

❌ Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.40%. Comparing base (5ced2cc) to head (2fa4994).
⚠️ Report is 5 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ermoderation/impl/RoomMemberModerationPresenter.kt	55.55%	2 Missing and 2 partials ⚠️
...es/roomdetails/impl/members/RoomMemberListState.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5959      +/-   ##
===========================================
- Coverage    81.40%   81.40%   -0.01%     
===========================================
  Files         2535     2535              
  Lines        67624    67626       +2     
  Branches      8669     8669              
===========================================
- Hits         55050    55049       -1     
- Misses        9365     9367       +2     
- Partials      3209     3210       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bmarty]

Thanks. A bit annoying that no unit tests have to be updated after this change. It means that some unit tests are missing.

[bmarty]

A detail, but maybe move the logic and comment to RoomMemberModerationPermissions like this:

// Unban requires both kick and ban permission instead of a dedicated unban permission
val canUnban = canKick && canBan

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud