Skip to content

Conversation

@jmartinesp
Copy link
Member

Content

  • Makes sure we don't obfuscate Metro related code. It's already convoluted enough as it is, and it doesn't expose anything.
  • Fixes the crash by changing JsonProvider into a typealias.
  • Does some cleanup in related DI code.

Motivation and context

Fixes #5947.

Tests

In a nightly/release version of the app, change the push provider to ntfy or Sunup. If it doesn't crash, it's fixed.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 16

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp requested a review from a team as a code owner December 22, 2025 13:21
@jmartinesp jmartinesp added the PR-Build For changes related to build, tools, CI/CD label Dec 22, 2025
@jmartinesp jmartinesp requested review from ganfra and removed request for a team December 22, 2025 13:21
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/FiQ65m

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.45%. Comparing base (00dcbf4) to head (57f8fbe).
⚠️ Report is 19 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5951      +/-   ##
===========================================
+ Coverage    81.41%   81.45%   +0.04%     
===========================================
  Files         2537     2536       -1     
  Lines        67569    67568       -1     
  Branches      8643     8643              
===========================================
+ Hits         55009    55036      +27     
+ Misses        9368     9340      -28     
  Partials      3192     3192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp enabled auto-merge (squash) December 22, 2025 14:14
@sonarqubecloud
Copy link

@surakin
Copy link
Contributor

surakin commented Dec 22, 2025

I can confirm this fixed the startup crash i had

@ganfra ganfra disabled auto-merge December 23, 2025 09:23
@ganfra ganfra merged commit 7423c43 into develop Dec 23, 2025
30 of 31 checks passed
@ganfra ganfra deleted the fix/crash-on-nightly-incorrect-di-cast branch December 23, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Build For changes related to build, tools, CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The app crashes in an infinite loop when the push gateway is changed.

4 participants