Skip to content

Sync Strings #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Sync Strings #4775

wants to merge 1 commit into from

Conversation

ElementBot
Copy link
Collaborator

  • Update Strings from Localazy

@ElementBot ElementBot added the PR-i18n For translations label May 26, 2025
@ElementBot ElementBot requested a review from a team as a code owner May 26, 2025 00:34
@ElementBot ElementBot requested review from jmartinesp and removed request for a team May 26, 2025 00:34
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 26, 2025
@ElementBot
Copy link
Collaborator Author

Messages
📖 This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by 🚫 dangerJS against 2f59adf

@@ -87,5 +87,6 @@
<string name="screen_server_confirmation_message_login_matrix_dot_org">"Matrix est un réseau ouvert pour une communication sécurisée et décentralisée."</string>
<string name="screen_server_confirmation_message_register">"C’est ici que vos conversations seront enregistrées, comme vous le feriez avec un fournisseur de messagerie pour conserver vos e-mails."</string>
<string name="screen_server_confirmation_title_login">"Vous êtes sur le point de vous connecter à %1$s"</string>
<string name="screen_server_confirmation_title_picker_mode">"Choisissez un fournisseur du compte"</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR I have fixed a typo here in Localazy (du -> de)

@bmarty
Copy link
Member

bmarty commented May 26, 2025

@jmartinesp this is not the first time we have issue with plural translations in cy. Last time I just deleted the wrong translations, but we will need to find a long term solution against this.

@jmartinesp
Copy link
Member

jmartinesp commented May 26, 2025

@jmartinesp this is not the first time we have issue with plural translations in cy. Last time I just deleted the wrong translations, but we will need to find a long term solution against this.

Do you think this is a problem in how Localazy processes the translations or is it coming from the original translations? I can't really make sense of what's its current state in Localazy.

EDIT: when looking at the exported JSON files instead of XML this issue is still there and the UI shows no translations for the default values. Maybe these translations were automated using the localazy platform and something broke internally, or they were batch-uploaded somehow with the wrong values 🫤 .

@jmartinesp
Copy link
Member

jmartinesp commented May 26, 2025

@Meddal sorry to ping you here, but it seems like the most direct way to get you notified about the issue with your submitted Welsh translations for the app. It looks like the tool you're probably using to upload these translations has some issue that send the translation keys as the values and viceversa for the plurals, like:

"digits_entered": {
      "%1$d nodau wedi eu cynnig": "zero", // Should be "zero": "%1$d nodau wedi eu cynnig" instead, same for the others
      "%1$d nod wedi ei gynnig": "one",
      "%1$d nod wedi eu cynnig": "other"
    },

The first translations you submitted were right, so maybe this bug started happening recently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-i18n For translations Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants