Skip to content

fix(deps): update dependency androidx.compose:compose-bom to v2025.04.01 #4631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 23, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
androidx.compose:compose-bom 2025.04.00 -> 2025.04.01 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label Apr 23, 2025
@renovate renovate bot requested a review from a team as a code owner April 23, 2025 20:02
@renovate renovate bot requested review from ganfra and removed request for a team April 23, 2025 20:02
@jmartinesp
Copy link
Member

This BOM version brings Compose 1.8.0 and that breaks lots of things, including our custom bottom sheet for the message composer. I can take a look if you want me to @ganfra .

@ganfra
Copy link
Member

ganfra commented Apr 24, 2025

This BOM version brings Compose 1.8.0 and that breaks lots of things, including our custom bottom sheet for the message composer. I can take a look if you want me to @ganfra .

Yes please if you have time 👍

Copy link
Contributor

github-actions bot commented Apr 24, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ZtPYu6

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 24, 2025
@jmartinesp jmartinesp self-assigned this Apr 24, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 24, 2025
@@ -18,7 +18,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.invisibleToUser
import androidx.compose.ui.semantics.hideFromAccessibility
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new name makes more sense!

Copy link
Contributor Author

renovate bot commented Apr 24, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@jmartinesp jmartinesp force-pushed the renovate/compose.bom branch from 8a8be2d to 903646a Compare April 24, 2025 14:21
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.01%. Comparing base (76e1612) to head (6a7c2e3).
Report is 45 commits behind head on develop.

Files with missing lines Patch % Lines
...in/impl/screens/loginpassword/LoginPasswordView.kt 61.53% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4631      +/-   ##
===========================================
+ Coverage    79.99%   80.01%   +0.02%     
===========================================
  Files         2107     2107              
  Lines        55811    55789      -22     
  Branches      6954     6957       +3     
===========================================
- Hits         44644    44640       -4     
+ Misses        8772     8755      -17     
+ Partials      2395     2394       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@jmartinesp
Copy link
Member

If we merge this, we should also revert the workaround added for #3414

@jmartinesp
Copy link
Member

Moving this to draft until the issue with clicking components with Outline.Generic in Robolectric UI tests is fixed: robolectric/robolectric#9595

The modal bottom sheet (and other rounded corner components) used rounded corner shapes where one or more of its corners weren't rounded. These were previously translated to Outline.RoundedCorner with those corners having radius 0, now they're translated to Outline.Generic with a custom path (maybe for performance reasons?) the problem is the path.op(path2, Intersect) operation never worked on Robolectric since it's not implemented in the ShadowPath class, which previously wasn't an issue but now it clearly is...

@jmartinesp jmartinesp marked this pull request as draft April 25, 2025 09:48
@bmarty bmarty mentioned this pull request May 13, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants