Skip to content

Add aria-describedBy to room list menus #30126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jun 11, 2025

On VoiceOver this just adds the the name of the room after 'More Options' and 'Notifications' even though it's already been spoken when you focused the room tile, which doesn't seem too helpful to me but it was explicitly requested.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

On VoiceOver this just adds the the name of the room after 'More Options'
and 'Notifications' even though it's already been spoken when you focused
the room tile, which doesn't seem too helpful to me but it was explicitly
requested.
@t3chguy
Copy link
Member

t3chguy commented Jun 12, 2025

This seems far too chatty to be a good idea, have you ran this by our a11y community? This seems like an XY problem.

@dbkr
Copy link
Member Author

dbkr commented Jun 12, 2025

Have asked the original requester.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants