Update the mobile_guide page to the new design. #30006
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract the CSS & SVGs from the page for easier sync with mobile.element.io - Update the webpack config to copy the extracted SVGs (webpack magic handles the CSS). - Initial implementation of the updated design (still more updates to come). - Allow the page to be configured for Element Classic, X and Pro. fixup
|
Ok, I don't understand, when I run locally with |
pixlwave
commented
May 22, 2025
| } | ||
|
|
||
| body { | ||
| background: #fff; |
There was a problem hiding this comment.
I haven't switched to using var(--cpd-color-*) yet as I'd like to figure out the best way to make this page easy to copy over to mobile.element.io.
pixlwave
commented
May 22, 2025
Comment on lines
+167
to
+187
| @media screen and (max-width: 1120px) { | ||
| body { | ||
| font-size: 16px; | ||
| } | ||
|
|
||
| h2 { | ||
| font-size: 16px; | ||
| } | ||
|
|
||
| .mx_Button { | ||
| font-size: 16px; | ||
| padding: 12px 16px; | ||
| } | ||
|
|
||
| .mx_HomePage_header { | ||
| justify-content: left; | ||
| } | ||
|
|
||
| .mx_Spacer { | ||
| margin-top: 48px; | ||
| } |
There was a problem hiding this comment.
I'm unsure if this is doing anything now, would it be ok to remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the mobile_guide page to match the new design that we're going to roll out on mobile.element.io (we would like both pages to look the same). It makes the following changes:
mobile_guide/assetsdirectory (for easy sync with mobile.element.io) and the CSS into an index.css page (adding a new copy rule for the SVGs).mobile_guide_app_varianttoconfig.json(please let me know if there's a better name or if I missed any steps when adding this).Checklist
public/exportedsymbols have accurate TSDoc documentation.