Skip to content

Mvvm split user info, create powerlevels component #30005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Mvvm split user info, create powerlevels component #30005

wants to merge 1 commit into from

Conversation

MarcWadai
Copy link
Collaborator

Part of task #29633 to mvvm right panel

Part 2 of splitting userInfo into three components :

UserInfoAdminToolsContainer
UserInfoPowerLevel (this PR)
UserInfoView

Changes

  • Remove PowerLevelsSection from right_panel userinfo
  • Create new component UserInfoAdminPowerLevels and corresponding VM
  • Updated userInfo-test.tsx to remove reference to powerselector components
  • Create UserInfoAdminPowerLevelsViewModel-test et UserInfoAdminPowerLevels-test

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 22, 2025
@MarcWadai MarcWadai force-pushed the 29633-mvvm-user-info-powerlevel branch from efc7cf3 to 37d4c06 Compare June 12, 2025 15:58
@MarcWadai MarcWadai marked this pull request as ready for review June 12, 2025 15:58
@MarcWadai MarcWadai requested a review from a team as a code owner June 12, 2025 15:58
@MarcWadai MarcWadai requested review from dbkr and MidhunSureshR June 12, 2025 15:58
dbkr
dbkr approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Few lint errors etc though.

src/components/viewmodels/right_panel/UserInfoPowerlevelViewModel.tsx
const applyPowerChange = (roomId: string, target: string, powerLevel: number): Promise<unknown> => {
return cli.setPowerLevel(roomId, target, powerLevel).then(
function () {
// NO-OP; rely on the m.room.member event coming down else we could
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems very confusing but it was there before so I guess now is not the time to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcWadai @dbkr