Skip to content

New room list: add context menu to room list item #29952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented May 13, 2025

Task https://github.com/element-hq/wat-internal/issues/204
Needs element-hq/compound-web#344

Add a context menu on the room list item. The context menu has the same content than the three dots menu.

Screencast_20250514_174203.webm

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behaviour is not quite right, if you right click again when a menu is already open it closes-and-reopens, unlike native menus & the existing room list behaviour where it closes.

room: Room;
/**
* Set the menu open state.
* @param isOpen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless jsdoc

@florianduros
Copy link
Member Author

The behaviour is not quite right, if you right click again when a menu is already open it closes-and-reopens, unlike native menus & the existing room list behaviour where it closes.

So the behaviour of the compound component is not right: https://compound.element.io/?path=/docs/compound-web_menu-contextmenu--docs. I'll update it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants