/share?msg=foo endpoint using forward message dialog #29874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
commented
May 17, 2025
| expect(defaultDispatcher.dispatch).toHaveBeenCalledWith({ | ||
| action: "share", | ||
| msg: "Hello", | ||
| format: "B", |
There was a problem hiding this comment.
Thank for sorting out tests. what's going on with the format: "B" here? shouldn't it be one of the string vals from the SharedFormat enum?
There was a problem hiding this comment.
True, it is typed so it probably ought to be one of the types.
ara4n
commented
May 17, 2025
dbkr
changed the title
|
I think this is ready now. After some trying & failing with the playwright tests (as commented) I think this is as much as we'll get without expanding this work to make the rooms displayed in the forward dialog update dynamically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic, functional interface to use the ForwardDialog to let users share arbitrary text messages into Matrix, similar to a mobile app's share extension. In addition to the unit / e2e tests, have manually successfully tested:
As of May 14th I've added sharing markdown & html formatted msgs too.
URI scheme is
/#/share?format={format}&msg={msg}where format is optional, can be one oftext,htmlormdbut defaults totextif missing.Checklist
public/exportedsymbols have accurate TSDoc documentation.