Hide buttons in the interface using additional options in the configuration file. #29848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton_creating_room view_button_creating_home view_button_export
|
|
github-actions
bot
added
the
Z-Community-PR
t3chguy
requested changes
Apr 29, 2025
| /> | ||
| )} | ||
|
|
||
| {/*Pro777 edit*/ !isVideoRoom && SettingsStore.getValue("view_button_export") && ( |
Member
There was a problem hiding this comment.
These comments seem unrelated to this project
Comment on lines
+359
to
+360
| // Pro777 edit | ||
| ///if (showCreateRoom || showExploreRooms) { |
Member
There was a problem hiding this comment.
Unrelated comment & commented out code
Comment on lines
+295
to
+298
| "view_button_creating_space": IBaseSetting<boolean>; | ||
| "view_button_creating_room": IBaseSetting<boolean>; | ||
| "view_button_creating_home": IBaseSetting<boolean>; | ||
| "view_button_export": IBaseSetting<boolean>; |
Member
There was a problem hiding this comment.
Should use the UIFeature. nomenclature
| {contextMenu} | ||
| </li> | ||
| ); | ||
| // Pro777 edit |
| } | ||
| } | ||
|
|
||
| // Pro777 edit |
| import SpaceContextMenu from "../context_menus/SpaceContextMenu"; | ||
| import InlineSpinner from "../elements/InlineSpinner"; | ||
| import { HomeButtonContextMenu } from "../spaces/SpacePanel"; | ||
| // Pro777 edit |
t3chguy
requested changes
Apr 29, 2025
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
The title says in the configuration file but then creates account settings, please align the title with the implementation.
Member
|
Closing due to no iteration based on review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiding buttons creating home, creating room, creating space and hiding export item.
Example in config.json: