Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement 'Knocking` #22926

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ankur12-1610
Copy link
Contributor

@ankur12-1610 ankur12-1610 commented Jul 24, 2022

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This PR is the part of PR: #9093


This change has no change notes, so will not be included in the changelog.

@SimonBrandner
Copy link
Contributor

You don't need to add the tralations in this layer, it's enough to add it to matrix-react-sdk

@ankur12-1610
Copy link
Contributor Author

@SimonBrandner sorry for closing the previous one 😅

@ankur12-1610
Copy link
Contributor Author

You don't need to add the tralations in this layer, it's enough to add it to matrix-react-sdk

Oh! I thought since they are related to each other translations in both repos will be required

@ankur12-1610
Copy link
Contributor Author

I'll let this PR open coz in future I'll do some changes in this repo and will update changes in the same PR.

@ankur12-1610 ankur12-1610 changed the title Added translations for knocking WIP: Implement 'Knocking` Jul 24, 2022
@ankur12-1610 ankur12-1610 marked this pull request as draft July 24, 2022 12:49
Comment on lines +32 to +33
"Anyone can knock on this room to join. You can change this at any time from room settings.": "Anyone can knock on this room to join. You can change this at any time from room settings.",
"Knocking": "Knocking"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't change the translation files manually - just use whatever yarn i18n gives you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agh! I did actually ran yarn i18n in element-web and these translations were not included in react-sdk so I thought that ot should be included in the PR😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this repo, your PR should be in labs.md :)

Signed-off-by: ankur12-1610 <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants