-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implement 'Knocking` #22926
base: develop
Are you sure you want to change the base?
WIP: Implement 'Knocking` #22926
Conversation
You don't need to add the tralations in this layer, it's enough to add it to |
@SimonBrandner sorry for closing the previous one 😅 |
Oh! I thought since they are related to each other translations in both repos will be required |
I'll let this PR open coz in future I'll do some changes in this repo and will update changes in the same PR. |
"Anyone can knock on this room to join. You can change this at any time from room settings.": "Anyone can knock on this room to join. You can change this at any time from room settings.", | ||
"Knocking": "Knocking" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't change the translation files manually - just use whatever yarn i18n
gives you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agh! I did actually ran yarn i18n
in element-web and these translations were not included in react-sdk so I thought that ot should be included in the PR😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this repo, your PR should be in labs.md :)
Signed-off-by: ankur12-1610 <[email protected]>
|
1 similar comment
|
Checklist
This PR is the part of PR: #9093
This change has no change notes, so will not be included in the changelog.