Input command should not be auto-corrected (#7424)#7462
Open
NicolasBuquet wants to merge 1 commit into
Open
Conversation
aringenbach
reviewed
Jun 12, 2023
Comment on lines
+23
to
+25
| // Triggers auto-correct if needed and if it is not a command. | ||
| let isCommand = self.textMessage.hasPrefix("/") | ||
| if self.isFirstResponder && !isCommand { |
Contributor
There was a problem hiding this comment.
I think the issue with that code is that it will only avoid triggering that last auto-correction that happens upon sending the message, and it will still still trigger upon typing.
I suppose we could do something similar that what the RTE does if it works: https://github.com/matrix-org/matrix-rich-text-editor/blob/main/platforms/ios/lib/WysiwygComposer/Sources/WysiwygComposer/Extensions/UITextView.swift
(triggered when the text changes, so we could evaluate that at the same moment we evaluate for mentions text trigger)
|
Nicolas Buquet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7424
Pull Request Checklist
Signed-off-by: Nicolas Buquet nicolas.buquet@beta.gouv.fr