Skip to content

Issue in height calculation for RTL text when there is headIndent and…#7289

Open
toshanmugaraj wants to merge 1 commit intoelement-hq:developfrom
toshanmugaraj:RTLReply
Open

Issue in height calculation for RTL text when there is headIndent and…#7289
toshanmugaraj wants to merge 1 commit intoelement-hq:developfrom
toshanmugaraj:RTLReply

Conversation

@toshanmugaraj
Copy link
Contributor

@toshanmugaraj toshanmugaraj commented Jan 22, 2023

Issue in height calculation for RTL text when there is headIndent and firstlineheadIndent. Fixes #7288

Signed-off-by: Shunmugaraj toshanmugaraj@gmail.com

Pull Request Checklist

  • [ x] I read the contributing guide
  • [ x] UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • [ x] Accessibility has been taken into account.
  • [ x] Pull request is based on the develop branch
  • [ x] Pull request contains a changelog file in ./changelog.d
  • [ x] You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • [x ] Pull request includes a sign off

… firstlineheadIndent.

Signed-off-by: Shunmugaraj toshanmugaraj@gmail.com
@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.97%. Comparing base (fdf1839) to head (006a7fa).
⚠️ Report is 1627 commits behind head on develop.

Files with missing lines Patch % Lines
...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m 0.00% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7289   +/-   ##
========================================
  Coverage    11.97%   11.97%           
========================================
  Files         1634     1634           
  Lines       161007   161025   +18     
  Branches     65851    65857    +6     
========================================
+ Hits         19283    19286    +3     
- Misses      141083   141098   +15     
  Partials       641      641           
Flag Coverage Δ
uitests 55.28% <ø> (-0.06%) ⬇️
unittests 4.40% <0.00%> (-1.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTL replies sometimes don't get rendered

2 participants